Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
flake8
🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1
blank line contains whitespace
🚫 [flake8] <266> reported by reviewdog 🐶
too many leading '#' for block comment
trailing whitespace
blank line contains whitespace
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
blank line contains whitespace
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
trailing whitespace
trailing whitespace
trailing whitespace
blank line contains whitespace
trailing whitespace
trailing whitespace
[flake8] <401> reported by reviewdog 🐶
'tkinter.Tk' imported but unused
[flake8] <401> reported by reviewdog 🐶
'tkinter.Text' imported but unused
[flake8] <401> reported by reviewdog 🐶
'tkinter.TOP' imported but unused
[flake8] <401> reported by reviewdog 🐶
'tkinter.N' imported but unused
[flake8] <401> reported by reviewdog 🐶
'tkinter.RIGHT' imported but unused
🚫 [flake8] <128> reported by reviewdog 🐶
continuation line under-indented for visual indent
🚫 [flake8] <128> reported by reviewdog 🐶
continuation line under-indented for visual indent
trailing whitespace
🚫 [flake8] <128> reported by reviewdog 🐶
continuation line under-indented for visual indent
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ':'
trailing whitespace
🚫 [flake8] <128> reported by reviewdog 🐶
continuation line under-indented for visual indent
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ':'
🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
blank line contains whitespace
blank line contains whitespace
blank line contains whitespace
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ':'
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <722> reported by reviewdog 🐶
do not use bare 'except'
🚫 [flake8] <251> reported by reviewdog 🐶
unexpected spaces around keyword / parameter equals
🚫 [flake8] <251> reported by reviewdog 🐶
unexpected spaces around keyword / parameter equals
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
blank line contains whitespace
🚫 [flake8] <225> reported by reviewdog 🐶
missing whitespace around operator
trailing whitespace
🚫 [flake8] <225> reported by reviewdog 🐶
missing whitespace around operator
blank line contains whitespace
🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1
🚫 [flake8] <302> reported by reviewdog 🐶
expected 2 blank lines, found 1
blank line contains whitespace
🚫 [flake8] <266> reported by reviewdog 🐶
too many leading '#' for block comment
trailing whitespace
blank line contains whitespace
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
blank line contains whitespace
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
🚫 [flake8] <231> reported by reviewdog 🐶
missing whitespace after ','
🚫 [flake8] <222> reported by reviewdog 🐶
multiple spaces after operator
trailing whitespace
trailing whitespace
trailing whitespace
blank line contains whitespace
trailing whitespace
trailing whitespace
|
@kback-ccdc could you add a ReadMe.md to this folder so it follows the same requirements as the rest of the scripts on this repo and then also edit https://github.com/ccdc-opensource/csd-python-api-scripts/blob/main/scripts/ReadMe.md with a short description please? |
| elif query_string in ("0","0.0"): | ||
| ll, ul = 0.0, 0.1 | ||
| else: | ||
| ll, ul = float(query_string)*0.95, float(query_string)*1.05 |
There was a problem hiding this comment.
I think this shouldn't apply to percolated dimensions
There was a problem hiding this comment.
Agree - I'll add something. It's still going to be that way under the hood - just makes it easier than figuring out inclusive / exclusive ranges in sql, but the report will be clean
pmbulit
left a comment
pmbulit
left a comment
There was a problem hiding this comment.
One minor request for now. If the ReadMe has additional info on expected behaviour I might have more comments
…ou check this is what you were try/excepting for, testing seems fine NO_JIRA
IsaacSugden
dismissed
pmbulit’s stale review
basic Readme added, Pablo, please have a look and feel free to raise request again
lines 201 - 204 , searches the right field now, and all have rounding included
|
IsaacSugden
left a comment
IsaacSugden
left a comment
There was a problem hiding this comment.
Looks good and fairly well tested by me. CK says he wants to add something for percolated dimensions at Pablo's request, but I'd be happy to merge before the webinar and add stuff like that later
4 participants
Adding Chris Kingsbury's Void Search script to the opensource repo for next week's webinar